Replaces DeveloperError(s) with Check(s) in Ellipsoid #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnimatedRNG
force-pushed
the
ellipsoid-check
branch
from
ae92872 to
08e2702
Compare
lilleyse
reviewed
Jun 6, 2017
Source/Core/Ellipsoid.js
Outdated
| throw new DeveloperError('All radii components must be greater than or equal to zero.'); | ||
| } | ||
| }*/ |
There was a problem hiding this comment.
Since this PR was submitted alongside #5424 it has some of the same issues. Do a pass over the file to make sure commented code is deleted, checks are within includeStart/includeEnd, and the appropriate Check.typeOf is used.
Source/Core/Ellipsoid.js
Outdated
| throw new DeveloperError('Ellipsoid must be an ellipsoid of revolution (radii.x == radii.y)'); | ||
| } | ||
|
|
||
| Check.typeOf.number.greaterThan('_radii.z', this._radii.z, 0); |
There was a problem hiding this comment.
Change the string to Ellipsoid.radii.z to better match the original error.
Source/Core/Ellipsoid.js
Outdated
| Check.defined('position', position); | ||
|
|
||
| // While it would be more idiomatic to use a Check.typeOf.number.something here, | ||
| // the resulting error message is a lot harder to read. |
There was a problem hiding this comment.
It's fine to remove this comment.
|
@AnimatedRNG after making code updates just leave a small message like "Updated" so everyone reviewing gets notified. |
|
There are still some areas with commented code and checks not within the debug pragmas. |
|
Updated |
lilleyse
reviewed
Jun 9, 2017
Source/Core/Ellipsoid.js
Outdated
| @@ -283,12 +285,16 @@ define([ | |||
| */ | |||
| Ellipsoid.pack = function(value, array, startingIndex) { | |||
| //>>includeStart('debug', pragmas.debug); | |||
| if (!defined(value)) { | |||
| /*if (!defined(value)) { | |||
Source/Core/Ellipsoid.js
Outdated
| if (!defined(cartesian)) { | ||
| throw new DeveloperError('cartesian is required.'); | ||
| } | ||
| Check.defined('cartesian', cartesian); |
There was a problem hiding this comment.
Use Check.typeOf.object here.
Source/Core/Ellipsoid.js
Outdated
| if (!defined(position)) { | ||
| throw new DeveloperError('position is required.'); | ||
| } | ||
| Check.defined('position', position); |
|
Updated |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4794